Stamp the tag-derived version into published assemblies#17
Merged
Conversation
release.yml derives the version from the git tag and passes it to vpk pack, but the dotnet publish step ran without -p:Version, so the in-process assembly stamps as 1.0.0 (the SDK default) and the About page would lie about which build the user is running. MSBuild handles "0.1.0-alpha.1"-style versions natively: it derives AssemblyVersion/FileVersion from the numeric prefix and uses the full string verbatim for InformationalVersion, which is what the About page reads. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlalready derives the version from the git tag and passes it tovpk pack, butdotnet publishran with no-p:Version, so the assembly would stamp as1.0.0(the SDK default) and the About expander would lie about which build the user is running.-p:Version=${{ steps.meta.outputs.version }}todotnet publish. MSBuild handles0.1.0-alpha.1natively (numeric prefix →AssemblyVersion/FileVersion; full string →InformationalVersion, which is what the About page reads).Test plan
v0.1.0-alpha.1should produce a Velopack package whose published exe reports0.1.0-alpha.1to the About page.🤖 Generated with Claude Code